Fix tests#669
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bhargaveede
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Feb 9, 2024
bhargaveede
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Feb 14, 2024
vivekgoe
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Feb 15, 2024
Co-authored-by: Sayantan Sarkar <supersarkar@gmail.com>
jychen21
pushed a commit
to jychen21/optimum-habana
that referenced
this pull request
Feb 27, 2024
HolyFalafel
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Mar 11, 2024
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
…ngface#669) Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Certain tests like these here calls
greedy_searchandbeam_searchdirectly without generateflags like
reduce_recompileandbucket_sizeare set to default values here, hence they were accessed without defaults ingreedy_searchandbeam_search. However of the *_search functions are called directly (like in the unit tests), it can fail.Therefore setting defaults in this PR
Fixes # (issue)
Before submitting